Theme Previewer: Fully hide all other page content when showing pattern previews #279
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the pattern preview code hides the content with the
visibility
property, which means it still takes up space on the page. The patterns are then transposed up the page to cover the top offset. In the current previews this is okay because the patterns are taken at a fixed height. The mshots screenshot block from the Pattern Directory takes full page screenshots, which clearly shows extra space under the pattern.This update changes the method of hiding the other page content
display: none
on all other content to hide it and prevent it from taking up space.display: none
.To test
@StevenDufresne Since you worked on this first, I'm sure you know more edge cases, so let me know if I've oversimplified things.