Plugins: Add sorting #313
Open
Plugins: Add sorting #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is effectively a cutdown version of #202 but specific for sort with the new plugin directory theme.
This enables a sorting dropdown on archives & search.
ZERO effort has been put into styling and getting the dropdowns in the correct locations on either search or archives.
It's worth noting that custom sorting is already enabled for non-search archives, just not exposed with a dropdown, for example,
tags/performance/?orderby=ratingSorting for search is arguably useless, as when you sort you immediately loose relevancy order in the results, and you end up with the same top-20 plugins showing up in every search in the first few places.
This requires a change to Jetpack Search on WordPress.com to allow us to sort by some fields, D148116, notably this is required for the
ratings,num_ratings,tested, andactive_installssorts. If you're an Automattician with a WordPress.com sandbox, you can test using the diff D148116 w/JETPACK__SANDBOX_DOMAIN.Trac: https://meta.trac.wordpress.org/ticket/2753