Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support Node.js v22 #243

Merged
merged 2 commits into from
Jun 5, 2024
Merged

feat: support Node.js v22 #243

merged 2 commits into from
Jun 5, 2024

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented May 7, 2024

node-pre-gyp http GET https://cdn.npmmirror.com/binaries/xprofiler/v2.6.0/xprofiler-v2.6.0-node-v127-darwin-arm64.tar.gz
node-pre-gyp ERR! install response status 404 Not Found on https://cdn.npmmirror.com/binaries/xprofiler/v2.6.0/xprofiler-v2.6.0-node-v127-darwin-arm64.tar.gz 
node-pre-gyp WARN Pre-built binaries not installable for xprofiler@2.6.0 and node@22.1.0 (node-v127 ABI, unknown) (falling back to source compile with node-gyp) 
node-pre-gyp WARN Hit error response status 404 Not Found on https://cdn.npmmirror.com/binaries/xprofiler/v2.6.0/xprofiler-v2.6.0-node-v127-darwin-arm64.tar.gz 

@fengmk2 fengmk2 added the enhancement New feature or request label May 7, 2024
@fengmk2 fengmk2 requested review from legendecas and hyj1991 May 7, 2024 02:19
@fengmk2
Copy link
Member Author

fengmk2 commented May 7, 2024

看来 windows 下需要升级 msbuild 的版本

@hyj1991
Copy link
Member

hyj1991 commented May 7, 2024

我看下

@legendecas
Copy link
Member

legendecas commented May 7, 2024

Windows 上 v22 失败原因: nodejs/node#52794

@fengmk2
Copy link
Member Author

fengmk2 commented May 22, 2024

Error: D:\a\xprofiler\xprofiler\src\platform\win\report_win.cc(166,20): error C2440: '=': cannot convert from 'const char [15]' to 'LPSTR' [D:\a\xprofiler\xprofiler\build\xprofiler.vcxproj]
D:\a\xprofiler\xprofiler\src\platform\win\report_win.cc(166,20):
Conversion from string literal loses const qualifier (see /Zc:strictStrings)

nodejs 22 windows 编译错误

@hyj1991
Copy link
Member

hyj1991 commented Jun 1, 2024

我再试下,还不行先合并了,看起来不是代码的问题,CI 等有空我再一并修下

@hyj1991 hyj1991 merged commit 2260972 into master Jun 5, 2024
30 of 42 checks passed
@hyj1991 hyj1991 mentioned this pull request Jun 5, 2024
@fengmk2 fengmk2 deleted the node-v22 branch June 5, 2024 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants