fix: manager库支持了sequelize库的使用 #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
这两个 pr 周末我确认下，感谢你的 pr |
hyj1991
requested changes
Jul 19, 2020
| return this.app.model.query(sql, { replacements: params, type: this.app.model.QueryTypes.SELECT }); | ||
| // const { ctx: { app: { mysql } } } = this; | ||
| // const xprofiler_logs = mysql.get('xprofiler_logs'); | ||
| // return xprofiler_logs.query(sql, params); | ||
| } | ||
|
|
There was a problem hiding this comment.
consoleQuery 和 logsQuery 在 seq 下如果都一致了，没必要区分两个方法了
|
|
||
| // redis | ||
| userConfig.redis = { | ||
| config.redis = { | ||
| client: { |
There was a problem hiding this comment.
用 userConfig，config 是原则上不需要配置的参数，用默认的 dfault 即可
| }, | ||
| // sequelize | ||
| config.sequelize = { | ||
| dialect: 'postgres', |
| // }, | ||
| // }; | ||
|
|
||
| // userConfig.xprofilerConsole = ''; | ||
|
|
| // password: '', | ||
| // db: 0, | ||
| // }, | ||
| // }; | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
manager库支持了sequelize库的使用