Better flarm colours #1295

GeorgeDowning20 · 2023-09-02T16:42:43Z

This PR shows FLARM targets in different colors according to their FLARM rate. 30s climb rates are compared to the largest between 30s average or set MC.

Red = climbing well (better than your 30s average/ MC)
Yellow = Climbing ok (worse than your 30s average/ MC but still climbing)
Blue = not climbing

light colours = >50 above
normal colours = same level
dark colours = >50m below

Potentially too confusing for most users, but also very powerful for comp pilots. I have been flying with it for a few comps, the main advantages are:

Bubble awareness -> Are gliders climbing better above or below? should you wait for that next pulse to hit?
spread of gliders -> who's climbing the best? are you in the best bit? who is actually climbing vs. circling? See if gaggles are centered, and guess where the core is before even getting there.
Next thermal -> are they out-climbing you? will you connect when you get there (are they at your level)?
Final glide -> Are gliders ahead pulling up in lift?

mlep · 2023-09-02T17:20:13Z

Shouldn't the red color for dangers?
Maybe use green instead.

GeorgeDowning20 · 2023-09-02T17:29:54Z

Shouldn't the red color for dangers? Maybe use green instead.

The alarm warning and Alert colors are still preserved. I would also perhaps argue, that no one actually uses that feature, because we all have flarm displays or similar dedicated for that job.

The colors are based on LX stuff, which works well for me. Also, is similar to the Vario #2 trace. perhaps I could add another one with green and grey like the default vario trace.

GeorgeDowning20 · 2023-09-02T20:28:28Z

Reading blackboard incorrectly, fix on way

lordfolken · 2023-09-05T05:47:50Z

Plesse
No fixup commits
Fix the codacy warnings
Fix the compile issues on osx

GeorgeDowning20 · 2023-09-05T09:43:41Z

Plesse No fixup commits Fix the codacy warnings Fix the compile issues on osx

👍 will sort issues and refactor PR once sorted.

Struggling to read the OSX compile log. not sure why its breaking?

Same with the codacy warnings: saying a member of struct is not used when it is?

G

lordfolken · 2023-09-05T10:30:12Z

Struggling to read the OSX compile log. not sure why its breaking?

Yes i also find these massive logs only partially useful.
src/Renderer/MapItemListRenderer.cpp:30:
./src/Renderer/TrafficRenderer.hpp:17:6: error: expected identifier
YES = 1,

same with The No.

lordfolken · 2023-09-05T10:34:13Z

src/Renderer/TrafficRenderer.cpp

@@ -29,6 +29,8 @@ TrafficRenderer::Draw(Canvas &canvas, const TrafficLook &traffic_look,
    { 0, 3 },
  };

+  if(colorful_traffic) printf("colorful_traffic\n");  //test


I guess this is a debug statement?

I assume this is a problem because it is part of the commit history, i will refactor PR and remove

src/Renderer/TrafficRenderer.hpp

src/Profile/MapProfile.cpp

MaxKellermann · 2023-09-11T16:45:28Z

Shouldn't the red color for dangers?

Red should be reserved for indicating danger and other urgent information. XCSoar already abuses red too much, and we shouldn't add more red.

GeorgeDowning20 · 2023-09-11T16:53:41Z

Can't seem to shake the codacy problems. it's saying a member of a struct is not used when it definitely is. I think the rest is good to go

GeorgeDowning20 · 2023-09-11T17:32:28Z

Shouldn't the red color for dangers?

Red should be reserved for indicating danger and other urgent information. XCSoar already abuses red too much, and we shouldn't add more red.

The color scheme is the same as LXNAV thermal Assist. it also Literally looks like one as well in a big gaggle. My opinion is the colors are very effective for this reason. It is not a safety feature. NB by default it is turned off.

Moving forward, If you agree to merge it with the current color scheme, I would be happy to mitigate the problem by doing one of the following:

Make it a "expert option" , note saying "WARNING, color scheme might mask immanant traffic".
teh above and Add an additional colour scheme using green and gray similar to Vario 1

I would insist the red, blue, and yellow colour scheme should remain as an option. I went through several itterations of color schemes and it is by far the best for a comp pilot.

cheers
G

MaxKellermann · 2023-09-11T18:29:32Z

If you insist on red, it will not be merged. I won't discuss this. This is a no-go.

MaxKellermann · 2023-09-11T18:40:09Z

Guidelines for the Use of Color in ATC Displays

Cultural color conventions (such as red for danger and yellow for warning) should not be violated.

This means that red should never mean anything but danger, alert, or warning.

red is best preserved for situations in which an immediate action is required.

when red is used, it should convey critical information.

DanD222 · 2023-09-11T20:15:37Z

Could we perhaps leave this open until we clarify how strong of an insistence on red there is from the other side? I would hate to see this go to waste and was looking forward to using this feature.

GeorgeDowning20 · 2023-09-11T20:39:19Z

Could we perhaps leave this open until we clarify how strong of an insistence on red there is from the other side? I would hate to see this go to waste and was looking forward to using this feature.

The first time I tried this feature was the final day of the uk club class nationals… I won the day… not a coincidence! It is a very powerful feature.

GeorgeDowning20 · 2023-09-11T20:40:07Z

Guidelines for the Use of Color in ATC Displays

Cultural color conventions (such as red for danger and yellow for warning) should not be violated.

This means that red should never mean anything but danger, alert, or warning.

red is best preserved for situations in which an immediate action is required.

when red is used, it should convey critical information.

Better get rid of the red vario trace then.

DanD222 · 2023-09-11T21:17:45Z

Yes, but I would rather have the features that I like converge in XCSoar rather than cherry-picking them from several forks and patches :(

Could we perhaps have a very basic colour picker for the three colours so that one can chose whatever colour one wants, with the default being, say, pink, rather than red, regardless of the current colour of the vario trace..?

GeorgeDowning20 · 2023-09-11T21:28:46Z

Yes, but I would rather have the features that I like converge in XCSoar rather than cherry-picking them from several forks and patches :(

Could we perhaps have a very basic colour picker for the three colours so that one can chose whatever colour one wants, with the default being, say, pink, rather than red, regardless of the current colour of the vario trace..?

If max agrees….

DanD222 · 2023-09-11T21:33:38Z

OK, that sounds promising, and seems like it could potentially lead to a compromise / workable solution - thanks.

MaxKellermann · 2024-01-04T10:47:30Z

NEWS.txt

@@ -14,7 +16,6 @@ Version 7.41 - 2023/12/21
 Version 7.40 - 2023/11/02
 * user interface
  - Added infobox that combines ETA with AAT dT
-  - FLARM: Add 100m zoom option.


Please do not remove that line. Please rebase to current head

src/Dialogs/Settings/Panels/SymbolsConfigPanel.cpp

src/Look/TrafficLook.cpp

MaxKellermann · 2024-01-04T10:55:08Z

src/Look/TrafficLook.hpp

+  static constexpr Color warning_in_altitude_range_color{0xff, 0x00, 0xff};
+  static constexpr Color alarm_color{0xfb, 0x35, 0x2f};
+
+   struct basic_traffic_brushes


MaxKellermann · 2024-01-04T10:55:43Z

src/Renderer/TrafficRenderer.cpp

-      } else {
-        canvas.Select(traffic_look.safe_below_brush);
-      }
+        if(colorful_traffic)


More bad indent and bad coding style. Please be more careful with that. It's everywhere.

red for Above MC yellow for Below MC but climbing Blue for sinking lighter for above Darker for below

lordfolken · 2024-04-03T20:37:32Z

src/Look/TrafficLook.hpp

+struct TrafficLook
+{
+  struct colorful_traffic_colors
+  {
+    struct above
+    {
+      static constexpr Color climb_good = {0xff, 0x66, 0x66}; // light red
+      static constexpr Color climb_up = {0xff, 0xff, 0x66};   // light yellow
+      static constexpr Color climb_down = {0x66, 0x66, 0xff}; // light blue
+    };
+
+    struct same
+    {
+      static constexpr Color climb_good = {0xff, 0x00, 0x00}; // red
+      static constexpr Color climb_up = {0xff, 0xff, 0x00};   // yellow
+      static constexpr Color climb_down = {0x00, 0x00, 0xff}; // blue
+    };
+
+    struct below
+    {
+      static constexpr Color climb_good = {0x99, 0x00, 0x00}; // dark red
+      static constexpr Color climb_up = {0x99, 0x99, 0x00};   // dark yellow
+      static constexpr Color climb_down = {0x00, 0x00, 0x99}; // dark blue
+    };
+  };
+
+  struct TrafficLookColor
+  {
+    static constexpr Color above = {0x1d, 0x9b, 0xc5};
+    static constexpr Color same = {0xff, 0x00, 0xff};


Colors are defined in src/ui/canvas/Color.hpp. There is even a function for darkening and lighting them. Please stick to those definitions.

Red is not a good color.
Find a different solution to display good climb.

green would be probably better anyhow.

lordfolken · 2024-04-03T20:38:05Z

src/FLARM/TrafficClimbAltIndicators.cpp

+   return GetClimbAltIndicators(traffic,
+                                CommonInterface::GetComputerSettings().polar.glide_polar_task.GetMC(),
+                                CommonInterface::Calculated().average);
+}


newline missing

lordfolken · 2024-04-03T20:38:15Z

src/FLARM/TrafficClimbAltIndicators.hpp

+   RelAlt rel_alt;
+
+   static constexpr int similar_altitude_threshold_meters = 50;
+};


newline missing

src/Renderer/TrafficRenderer.cpp

lordfolken

Pretty good.
Please fix any style issues, such as indents, brackets etc.
https://xcsoar.readthedocs.io/en/latest/policy.html#code-style as a guideline.
Please rebase. (git pull upstream/master --rebase)
Then there is the bike shed discussion concerning the color red.

GeorgeDowning20 · 2024-04-03T20:55:51Z

Pretty good. Please fix any style issues, such as indents, brackets etc. https://xcsoar.readthedocs.io/en/latest/policy.html#code-style as a guideline. Please rebase. (git pull upstream/master --rebase) Then there is the bike shed discussion concerning the color red.

👍. The I just changed to red temporarily for my start of season cherrypick. Will change back to pink, and sort coding style things tommorow.

GeorgeDowning20 requested a review from a team as a code owner September 2, 2023 16:42

GeorgeDowning20 closed this Sep 2, 2023

GeorgeDowning20 reopened this Sep 2, 2023

lordfolken reviewed Sep 5, 2023

View reviewed changes

src/Renderer/TrafficRenderer.hpp Show resolved Hide resolved

lordfolken reviewed Sep 5, 2023

View reviewed changes

src/Profile/MapProfile.cpp Outdated Show resolved Hide resolved

GeorgeDowning20 marked this pull request as draft September 5, 2023 10:43

GeorgeDowning20 force-pushed the Better-Flarm-Colours branch from f541bff to 3c41f20 Compare September 11, 2023 15:50

GeorgeDowning20 closed this Sep 11, 2023

GeorgeDowning20 force-pushed the Better-Flarm-Colours branch from 3c41f20 to c58e1c7 Compare September 11, 2023 15:51

GeorgeDowning20 reopened this Sep 11, 2023

GeorgeDowning20 marked this pull request as ready for review September 11, 2023 16:53

MaxKellermann closed this Sep 11, 2023

GeorgeDowning20 force-pushed the Better-Flarm-Colours branch from fc4025a to e04db63 Compare December 25, 2023 20:04

GeorgeDowning20 marked this pull request as draft December 25, 2023 21:12

GeorgeDowning20 force-pushed the Better-Flarm-Colours branch 7 times, most recently from 314743d to 3922bfe Compare December 26, 2023 02:35

GeorgeDowning20 marked this pull request as ready for review December 26, 2023 02:48

MaxKellermann reviewed Jan 4, 2024

View reviewed changes

src/Dialogs/Settings/Panels/SymbolsConfigPanel.cpp Outdated Show resolved Hide resolved

MaxKellermann reviewed Jan 4, 2024

View reviewed changes

src/Look/TrafficLook.cpp Outdated Show resolved Hide resolved

MaxKellermann reviewed Jan 4, 2024

View reviewed changes

src/Look/TrafficLook.cpp Outdated Show resolved Hide resolved

MaxKellermann reviewed Jan 4, 2024

View reviewed changes

GeorgeDowning20 marked this pull request as draft February 28, 2024 12:28

GeorgeDowning20 force-pushed the Better-Flarm-Colours branch 2 times, most recently from c8ca9a8 to 35f37bc Compare April 3, 2024 16:06

Add option to show colour of FLARM using vario.

db4dcb5

red for Above MC yellow for Below MC but climbing Blue for sinking lighter for above Darker for below

GeorgeDowning20 force-pushed the Better-Flarm-Colours branch from 35f37bc to db4dcb5 Compare April 3, 2024 16:47

lordfolken reviewed Apr 3, 2024

View reviewed changes

src/Renderer/TrafficRenderer.cpp Show resolved Hide resolved

lordfolken reviewed Apr 3, 2024

View reviewed changes

src/Renderer/TrafficRenderer.cpp Show resolved Hide resolved

lordfolken requested changes Apr 3, 2024

View reviewed changes

lordfolken removed the needs-work this closed pull request requires some action to be merged label Jun 2, 2024

lordfolken added this to the v7.44 milestone Jun 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Better flarm colours #1295

Better flarm colours #1295

GeorgeDowning20 commented Sep 2, 2023

mlep commented Sep 2, 2023

GeorgeDowning20 commented Sep 2, 2023

GeorgeDowning20 commented Sep 2, 2023

lordfolken commented Sep 5, 2023

GeorgeDowning20 commented Sep 5, 2023

lordfolken commented Sep 5, 2023

lordfolken Sep 5, 2023

GeorgeDowning20 Sep 11, 2023

MaxKellermann commented Sep 11, 2023

GeorgeDowning20 commented Sep 11, 2023

GeorgeDowning20 commented Sep 11, 2023 •

edited

MaxKellermann commented Sep 11, 2023

MaxKellermann commented Sep 11, 2023

DanD222 commented Sep 11, 2023

GeorgeDowning20 commented Sep 11, 2023

GeorgeDowning20 commented Sep 11, 2023

DanD222 commented Sep 11, 2023 •

edited

GeorgeDowning20 commented Sep 11, 2023

DanD222 commented Sep 11, 2023

MaxKellermann Jan 4, 2024

lordfolken Apr 3, 2024

MaxKellermann Jan 4, 2024

MaxKellermann Jan 4, 2024

lordfolken Apr 3, 2024

lordfolken Apr 3, 2024

lordfolken Apr 3, 2024

lordfolken Apr 3, 2024

lordfolken left a comment

GeorgeDowning20 commented Apr 3, 2024

Better flarm colours #1295

Are you sure you want to change the base?

Better flarm colours #1295

Conversation

GeorgeDowning20 commented Sep 2, 2023

mlep commented Sep 2, 2023

GeorgeDowning20 commented Sep 2, 2023

GeorgeDowning20 commented Sep 2, 2023

lordfolken commented Sep 5, 2023

GeorgeDowning20 commented Sep 5, 2023

lordfolken commented Sep 5, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MaxKellermann commented Sep 11, 2023

GeorgeDowning20 commented Sep 11, 2023

GeorgeDowning20 commented Sep 11, 2023 • edited

MaxKellermann commented Sep 11, 2023

MaxKellermann commented Sep 11, 2023

DanD222 commented Sep 11, 2023

GeorgeDowning20 commented Sep 11, 2023

GeorgeDowning20 commented Sep 11, 2023

DanD222 commented Sep 11, 2023 • edited

GeorgeDowning20 commented Sep 11, 2023

DanD222 commented Sep 11, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lordfolken left a comment

Choose a reason for hiding this comment

GeorgeDowning20 commented Apr 3, 2024

GeorgeDowning20 commented Sep 11, 2023 •

edited

DanD222 commented Sep 11, 2023 •

edited