add driver for Fenix device

[markus2marks]

Your PR should:

• all description should be in the commit messages (no text in the pr)
• your pr should be rebased on the current HEAD
• one commit per atomic feature (every commit should build)
• no fixup commits
• pass all the compile and CI targets

For coding, style guide, architecture information please see our development guide:
https://xcsoar.readthedocs.io/en/latest/index.html

[markus2marks]

it's the first time for me that i add something in XCSoar, how can i start the CI tests?

[lordfolken]

it's the first time for me that i add something in XCSoar, how can i start the CI tests?

As its your first time a project member has to approve them.

[markus2marks]

can you start the CI again please?

[lordfolken]

Just for the record the macosx failure is in master And not your PR.

Please cleanup your git history with proper formatted commits and commit messages.
Please respect code and comment style.
Please dont duplicate code. Import stuff from the class of lxnav or better yet structure those commits centrally.
Things like cout are not acceptable.

In general your git commits should be like a a Lego kit. Corrections etc I don't want in the git history.

[markus2marks]

Most of the functions of the LX driver are static, I cannot import them. Should the Fenix driver inherit the functions of the LX driver? or what are your suggestions to solve this problem?
I would only use the LXWP1 function from the LX driver

[lordfolken]

First get the PR in order. Dont merge rebase your commits.

[MaxKellermann]

strncpy, wtf!

[markus2marks]

quick and dirty ;) whats your suggestion for it?

[lordfolken]

Besides the code issue, we need a clean git history.
This article explains how to rebase and push code to a branch
https://docs.gitlab.com/ee/topics/git/git_rebase.html
Maybe this helps you?

[markus2marks]

Yes, I will clean it up when I have time, at the moment I'm busy with my work ;)