Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

egl/ConfigChooser.cpp: Add EGL_ALPHA_SIZE to ANDROID #1422

Closed
wants to merge 1 commit into from
Closed

egl/ConfigChooser.cpp: Add EGL_ALPHA_SIZE to ANDROID #1422

wants to merge 1 commit into from

Conversation

lordfolken
Copy link
Contributor

Your PR should:

  • all description should be in the commit messages (no text in the pr)
  • your pr should be rebased on the current HEAD
  • one commit per atomic feature (every commit should build)
  • no fixup commits
  • pass all the compile and CI targets

For coding, style guide, architecture information please see our development guide:
https://xcsoar.readthedocs.io/en/latest/index.html

@lordfolken lordfolken requested a review from a team as a code owner May 7, 2024 19:09
@lordfolken lordfolken linked an issue May 7, 2024 that may be closed by this pull request
crash during initialising display #1416
Open
@ubx
Copy link
Contributor

ubx commented May 7, 2024

Tested on virtual devices, Android 6.0 x86_64 and Android 13.0 x86_64. Works, no crash 👍

@ggajoch ggajoch mentioned this pull request May 10, 2024
Open
@lordfolken lordfolken removed a link to an issue May 31, 2024
crash during initialising display #1416
Open
@lordfolken lordfolken linked an issue May 31, 2024 that may be closed by this pull request
crash during initialising display #1416
Open
@lordfolken lordfolken removed a link to an issue Jun 2, 2024
crash during initialising display #1416
Open
@lordfolken
Copy link
Contributor Author

merged in 07e4ae1

@lordfolken lordfolken closed this Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lordfolken @ubx