Make map Orientation fully configurable by input events #1426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lordfolken
approved these changes
May 19, 2024
This adds an event that can change the orientation in cruise, as the current "Orientation" event is incomplete. Since one input can trigger multiple events it is not needed to mix cruise and circling orientation in one event, like "Orientation" tries (this would need 25 combinations vs two sets of 5 when split)
This adds an event that can change the orientation in circling, as the current "Orientation" event is incomplete. Since one input can trigger multiple events it is not needed to mix cruise and circling orientation in one event, like "Orientation" tries (this would need 25 combinations vs two sets of 5 when split)
Map orientation is completly configiruable with input events after this PR thus this TODO is done.
No more needed as it is replaced with eventOrientationCruise and eventOrientationCircling. However removing this will break users inputfile if they used the eventOrientation. Which they can easily fix by updating it.
lordfolken
force-pushed
the
Orientation-events
branch
from
1f999fa
to
4184ed5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your PR should:
For coding, style guide, architecture information please see our development guide:
https://xcsoar.readthedocs.io/en/latest/index.html