Feature/repeat pages #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenbutongit
force-pushed
the
feature/repeat-pages
branch
2 times, most recently
from
bb2222a
to
2034034
Compare
jenbutongit
force-pushed
the
feature/repeat-pages
branch
2 times, most recently
from
a3ee685
to
2830ea9
Compare
jenbutongit
force-pushed
the
feature/repeat-pages
branch
from
2830ea9
to
758a30c
Compare
superafroman
reviewed
Jul 3, 2020
engine/src/page.js
Outdated
| const updateValue = { [this.path]: update[this.section.name] } | ||
| const sectionState = state[this.section.name] | ||
| let updateValue = {[this.path]: update[this.section.name]} | ||
| let sectionState = state[this.section.name] |
There was a problem hiding this comment.
Is this an auto format thing? Should be const from what I can see?
engine/src/page.js
Outdated
| if (!sectionState) { | ||
| update = { [this.section.name]: [updateValue] } | ||
| } else if (!sectionState[num - 1]) { | ||
| } else if(!sectionState[num-1]) { |
There was a problem hiding this comment.
Auto formatting again? Spacing heere is good - don't we have a standard formatter?
There was a problem hiding this comment.
maybe merge issue, sorry! Might be that engine doesn't have linter installed and/or not running on test. I'll add.
andymoody
reviewed
Jul 3, 2020
| const nextLink = this.next.find(link => { | ||
| const { page, condition } = link | ||
| const value = page.section ? state[page.section.name] : state | ||
| getNextPage (state, suppressRepetition = false) { |
There was a problem hiding this comment.
neat, didn't know we could do parameter defaulting :D
There was a problem hiding this comment.
JS is a lot nicer these days :)
|
It looks like babel-eslint/eslint wont be supporting private methods until babel v8. babel/babel#10752, babel/babel-eslint#801. Ignoring for now. |
…quashed commits) Squashed commits: [46905cf] Fix duplicate questions when formatting webhook data. [cbb0fb4] Fix webhook data type. [688ccfe] Ignore EPIPE error when uploading documents. This error is returned when a response has been received before the request has finished sending. [2034034] lint [61ad037] oops. get rid of these [9aab773] move Key into object so it can be stubbed nicely. dynamic tests [2f81e9c] don't push all repeatable data to summary [b139a85] Webhook data updated with repeatable logic [9973cbb] Summary page working with repeatable pages. Section headers correct. [4de54bb] fix webhook data [a2badf6] oops. reset counter was in wrong place [8a744ff] oops revert to this [f26c95d] split out row [5b55fa7] revert test.json, dynamic pages looping + reading values. return [fceaae9] wip.. almost..! [0298514] summary does not error, dont rely on null value for summary.js..! [4349bfa] wip [af7bf4d] private method/props. reading state for repeatable pages [40d7174] state wip [f79ab6b] looping, probably [dd31960] wip [dba8b3a] wip [a007995] sourcemaps, add hoek [993f834] **Runner** - N/A **Designer** - N/A **Engine** - babel for engine. export everything in index
jenbutongit
force-pushed
the
feature/repeat-pages
branch
from
0bea6dc
to
ca3de3b
Compare
superafroman
approved these changes
Jul 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Repeatable pages support! This is currently a developer only feature (so no support in designer for it right now.)
sectionName: [{/page-1: {...}, /page-2: {...}}]to keep track of which pages have been "completed". Each array item is 1 "iteration" of the repeatable section.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Use dynamic.json inside
runner/test/casesif you would like to "play" a repeatable form.Checklist: