Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AmmBid expects BidMax to be of type IssuedCurrencyAmount but it can be a string #529

Open
exp0nge opened this issue May 2, 2024 · 1 comment · May be fixed by #534
Open

AmmBid expects BidMax to be of type IssuedCurrencyAmount but it can be a string #529

exp0nge opened this issue May 2, 2024 · 1 comment · May be fixed by #534

Comments

@exp0nge
Copy link

exp0nge commented May 2, 2024

The current JSON deserializer expects BidMax to be of IssuedCurrencyAmount, however, as observed on mainnet, this is not always the case:

https://xrpscan.com/ledger/BAA4AF508E9A9CB7685D9E61B82486681E52E9B920904B0650499497F050D8FA
Tx https://xrpscan.com/tx/6A8BC948E1309219EA8E14905D0EA9BB94E24429DE5B15CDE8916CDBCE42034B provides a string value of "10"
@exp0nge exp0nge changed the title AmmBid expects BixMax to be of type IssuedCurrencyAmount but it can be a string AmmBid expects BidMax to be of type IssuedCurrencyAmount but it can be a string May 2, 2024
@exp0nge exp0nge mentioned this issue May 10, 2024
Open
@nkramer44
Copy link
Collaborator

Those fields were typed as IssuedCurrencyAmounts because the docs say that bids are made using LP tokens, though it looks as though the docs are incorrect. I'll work on a fix for this shortly.

@nkramer44 nkramer44 linked a pull request May 18, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix 529: Make all AMM transaction IssuedCurrencyAmount fields CurrencyAmounts XRPLF/xrpl4j
2 participants
@exp0nge @nkramer44