Fix 529: Make all AMM transaction IssuedCurrencyAmount fields CurrencyAmounts #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #534 +/- ##
=========================================
Coverage 91.65% 91.65%
Complexity 1774 1774
=========================================
Files 365 365
Lines 4948 4948
Branches 408 408
=========================================
Hits 4535 4535
Misses 280 280
Partials 133 133 ☔ View full report in Codecov by Sentry. |
|
Any idea when this PR will be fixed & a release cut? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #529 by retyping all
IssuedCurrencyAmounts in AMM related transactions toCurrencyAmounts.This does not constitute a breaking change, because these transactions were marked
@Beta.