Refactor Prometheus variables to make use of optionals #842
+31
−75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phillebaba
force-pushed
the
refactor/prometheus-variables
branch
3 times, most recently
from
44345e2
to
b0f3850
Compare
phillebaba
force-pushed
the
refactor/prometheus-variables
branch
from
b0f3850
to
b03c556
Compare
|
Make sure to update https://github.com/XenitAB/xkf-templates accordingly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors Prometheus configuration and makes use of optional. This will hopefully reduce the need to repeat default values that risks making them wrong. It also removes some variables that are no longer needed that just increase the complexity.