Update commander to the latest version #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeoSot
force-pushed
the
update-commander-version
branch
from
fd1b5f1
to
b8c67a9
Compare
danny007in
reviewed
Mar 8, 2021
XhmikosR
force-pushed
the
update-commander-version
branch
from
1bfd2f9
to
3488273
Compare
danny007in
reviewed
Mar 8, 2021
danny007in
reviewed
Mar 8, 2021
XhmikosR
force-pushed
the
update-commander-version
branch
from
3488273
to
f3f9d87
Compare
XhmikosR
reviewed
Mar 8, 2021
cli.js
Outdated
| const chalk = require('chalk'); | ||
| const { version } = require('./package.json'); | ||
| const fusv = require('.'); | ||
|
|
||
| commander | ||
| program | ||
| .usage('[options] <folders...>') | ||
| .version(version, '-v, --version') | ||
| .option('-i, --ignore <ignoredVars>', 'ignore variables, comma separated') |
There was a problem hiding this comment.
@GeoSot this still doesn't use the variadic option ... https://github.com/tj/commander.js/#variadic-option
Wouldn't using this simplify things?
There was a problem hiding this comment.
I tried to keep things the same as possible.
It can be done. Although the $ prefix in each var, will have to be escaped.
I propose to leave it as it is and we can change it in a next pr
There was a problem hiding this comment.
Not our job to escape it, I think? I tested it with the default Windows cmd and it seems to work fine here.
C:\Users\xmr\Desktop\find-unused-sass-variables>npm run check -- --ignore $unused
> find-unused-sass-variables@3.1.0 check C:\Users\xmr\Desktop\find-unused-sass-variables
> node ./cli.js tests/ non-existent-folder/ -i "$a" "--ignore" "$unused"
Looking for unused variables
Finding unused variables in "C:\Users\xmr\Desktop\find-unused-sass-variables\tests"...
9 total variables.
6 are not used!
Variable $b is not being used!
Variable $black is not being used!
Variable $ignored-variable is not being used!
Variable $enabled-variable is not being used!
Variable $nestedVar is not being used!
Variable $nestNestedVar is not being used!
Finding unused variables in "C:\Users\xmr\Desktop\find-unused-sass-variables\non-existent-folder"...
"C:\Users\xmr\Desktop\find-unused-sass-variables\non-existent-folder": Not a valid directory!
There was a problem hiding this comment.
not in linux :/
> node ./cli.js tests/ non-existent-folder/ -i "$a" "--ignore" "$unused"
{ ignore: [ '', '' ] }
> node ./cli.js tests/ non-existent-folder/ -i '$a' --ignore '$unused' 'b'
{ ignore: [ '$a', '$unused', 'b' ] }
There was a problem hiding this comment.
All right, I'll revert the variadic change and we can tackle it along with the '' in another PR :)
XhmikosR
force-pushed
the
update-commander-version
branch
from
f3f9d87
to
a64c198
Compare
XhmikosR
reviewed
Mar 8, 2021
Also, refactor cli code a bit
XhmikosR
force-pushed
the
update-commander-version
branch
from
317fe6c
to
5d1b8be
Compare
XhmikosR
approved these changes
Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #100
Closes #128 by superseding it