Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Ratatui #42

Merged
merged 2 commits into from Dec 31, 2023
Merged

Migrate to Ratatui #42

merged 2 commits into from Dec 31, 2023

Conversation

joshka
Copy link
Contributor

@joshka joshka commented Dec 27, 2023

Ratatui is a replacement for tui-rs that is actively maintained.
See https://ratatui.rs/ for more info.

Ratatui is a replacement for tui-rs that is actively maintained.
See https://ratatui.rs/ for more info.
anyhow = "1.0"
clap = { version = "4.2", features = ["derive"] }
tempfile = "3.5"
regex = "1.8"
csv-sniffer = "0.3.1"

[target.'cfg(windows)'.dependencies]
crossterm = "0.25"
crossterm = "0.27.0"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible keep this pinned at 0.25 for windows? This is due to an on-going issue in crossterm. More info: #30

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 3ce170a

Usually apps can filter to only include key_event.kind == Press to workaround this.
Is there a need to handle release events in this app? I didn't see anything obvious.

See ratatui-org/ratatui#347 for more info.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I think this should work. Thanks for the fix.

@YS-L
Copy link
Owner

YS-L commented Dec 31, 2023

Thank you @joshka!

Crossterm 0.26+ reports key release events on windows, which results in
the application seeing multiple events for a single key press.

See ratatui-org/ratatui#347 for more info.

Fixes YS-L#30
@YS-L YS-L merged commit fe09917 into YS-L:main Dec 31, 2023
6 checks passed
@joshka joshka deleted the ratatui branch December 31, 2023 09:32
@joshka
Copy link
Contributor Author

joshka commented Dec 31, 2023

Not a problem. I've added this to the app showcase at https://ratatui.rs/showcase/apps/#csvlens
I redid your example demo using VHS to be a bit smaller and use a larger font size. See ratatui-org/ratatui-website#329 for details.

@YS-L
Copy link
Owner

YS-L commented Jan 1, 2024

@joshka That's awesome! Thanks for adding csvlens to the page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants