Skip to content
This repository has been archived by the owner on Jul 15, 2019. It is now read-only.

Adding tests, fixing undefined deps issue and fixes inject hard lazy bundle map issue #1

Merged
merged 1 commit into from
May 4, 2016

Conversation

tufandevrim
Copy link
Contributor

@tufandevrim tufandevrim commented May 4, 2016

This PR

@juandopazo

@tufandevrim tufandevrim changed the title Adding test for simple use case Adding test for simple use case and fixing undefined deps issue May 4, 2016
@tufandevrim tufandevrim force-pushed the simpleTest branch 5 times, most recently from 452d274 to 368afe7 Compare May 4, 2016 08:00
@tufandevrim tufandevrim changed the title Adding test for simple use case and fixing undefined deps issue Adding tests, fixing undefined deps issue and fixes inject hard lazy bundle map issue May 4, 2016
@@ -1,7 +1,7 @@
{
"name": "extractify",
"private": true,
"version": "0.0.1",
"version": "0.0.2",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need to change, but let's discuss bumping per commit versus bumping per NPM push. I would say bumping per push is preferable for a number of reasons.

@irae
Copy link
Collaborator

irae commented May 4, 2016

Please, change the setTimeout before merging this PR. The other comments are just ideas for improvements for other PRs. The setTimeout can really break the tests depending on where you run the tests and give false negatives.

@juandopazo
Copy link
Collaborator

I don't have any feedback other than what Irae commented.

@tufandevrim
Copy link
Contributor Author

Removing setTimeout will require refactoring on how we bundle the lazy bundles. So I will create a separate PR for only this purpose which will stream the src if no outfile specified in extractify config just like how browserify does.

@tufandevrim tufandevrim merged commit f35c218 into master May 4, 2016
@tufandevrim tufandevrim deleted the simpleTest branch May 4, 2016 22:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants