TRON-2185: cleanup mesos docs in Tron #964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemacysts
approved these changes
May 15, 2024
README.md
Outdated
Comment on lines
31
to
33
| * <= v0.6.2 - Stable version, recommended for non-Yelp installations. | ||
| * >= v1.0.0 - Stable mesos-based version | ||
| * \>= v1.0.0 & <= v1.32.0 - Stable mesos-based version | ||
| * \> v1.32.0 - Stable Kubernetes version |
There was a problem hiding this comment.
imo, it'd be fine to remove these versions recommendations :)
(we're really just developing in the open, i don't think we're really assuming that non-yelpers will ever use this :p)
README.md
Outdated
| It is being transformed from an ssh-based execution engine to a [Mesos | ||
| framework](http://mesos.apache.org/documentation/latest/frameworks/). | ||
| It is being transformed from an ssh-based execution engine to a [Kubernetes | ||
| framework](https://kubernetes.io/docs/concepts/overview/). |
There was a problem hiding this comment.
framework had a specific meaning in mesos - but i think this is still fine :)
cuza
approved these changes
May 22, 2024
nemacysts
reviewed
May 22, 2024
fix typo Co-authored-by: Luis Pérez <luisp@yelp.com>
nemacysts
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the build status icons in the README and removes references to Mesos