-
Notifications
You must be signed in to change notification settings - Fork 874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge company or person and social profiles in onboarding wizard #12563
Merge company or person and social profiles in onboarding wizard #12563
Conversation
…on-and-social-profiles-in-onboarding-wizard
…on-and-social-profiles-in-onboarding-wizard
Not sure why the select in the Settings page is using an aria-label instead of a visible There's already some visible text that can be used as a Visible Also, the current aria-label doesn't match the visible text (whether it's a label or not): Speech input users will try to voice a command based on the visible text e.g. "Click Choose whether the site represents..." and that won't work. Overall, I'd recommend to just use the existing visible text as a Also, the visible text and the default option text are pretty much the same and a bit repetitive:
I'd consider to simplify at least the default option. Can't test the configuration wizard as there's something wrong in my build and I'm getting JS errors. |
Re: Edit: on MyYoast the last usages of |
@@ -52,40 +52,67 @@ exports[`UpsellBox renders the snippet editor inside of it 1`] = ` | |||
</a> | |||
test | |||
</p> | |||
<UpsellBox__StyledList | |||
<.UpsellBox__StyledList-gjf66g-0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is there a .
in front of this component?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably a bug in jest-styled-components
. We should upgrade to 7.* as soon as it is released (it is currently in beta).
…on-and-social-profiles-in-onboarding-wizard
…on-and-social-profiles-in-onboarding-wizard
Merging with consent of @moorscode |
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
react-select
for selecting a WordPress user.Test instructions
Designs followed: https://github.com/Yoast/design/issues/315
This PR can be tested by following these steps:
UI changes
Quality assurance
Requires Yoast/javascript#184
Requires Yoast/javascript#193
Fixes #12516
Fixes #12519