Add upsell for Local SEO to search appearance #12646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This outputs the difference in style of styled-components to the snapshots. Making the right-to-left style difference testable with snapshots. Update existing snapshots to match.
…psell-for-local-seo-to-search-appearance
|
While looking at Yoast/javascript#220 I see that the adding of |
|
CR 👍 |
…moved a11y attributes
|
Acceptance 🚧 |
|
I'm not getting this reproduced, but I did get a nice plugin from Alexander to be able to test this easier! Install test pluginSee https://github.com/Yoast/Wiki/wiki/Filter-the-subscriptions-response-in-the-addon-manager-request |
|
@IreneStr I cannot reproduce your situation either. But should we look into it again before merging this PR? |
|
It looks like it was cache-related, so it can be merged after your thumbs up @johannadevos |
|
Acceptance 👍 |
johannadevos
deleted the
2127-ad-upsell-for-local-seo-to-search-appearance
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
react-svg-loader, which turns it into a component.wpseo-local-seo-upsell). Then the component is mounted on that depending on whether we want the upsell there or not. I left this because adding more logic in the PHP view is not really nice either. If you have a strong opinion about this, please share.Test instructions
This PR can be tested by following these steps:
Viewing the upsell.
Organizationas representation under theKnowledge Graphsetting.Install the helper plugin to manipulate the license
SEO -> Premiumpage (see Irene's screenshot). Which is also where you can see the current status.The upsell should only show when you do not have an active Local SEO license.
This is a bit tricky as it depends on which licenses are active on your site.You can create another vagrant box to test a site without a license.Or you can edit the PHP code. Inadmin/class-config.phpon line 143 change the value ofshowLocalSEOUpsellintotrueorfalse.expiryDatein the helper plugin to a date in the past (2019-01-27T01:00:00.000Z).SEO -> Premiumpage to see if the status of Local SEO is indeedNOT ACTIVATED.expiryDatein the helper plugin to a date in the future (2019-12-27T01:00:00.000Z).SEO -> Premiumpage to see if the status of Local SEO is indeedACTIVATED.The upsell should only show when you are in Free, never in Premium.
There is RTL support.
The link should contain UTM tags and other info
https://yoast.com/wordpress/plugins/local-seo/#utm_source=yoast-seo&utm_medium=software&utm_term=local-seo-kb-notification&utm_content=settings&utm_campaign=wordpress-adphp_versionandplatform_version.Screenshot
UI changes
Quality assurance
Fixes https://github.com/Yoast/wordpress-seo-premium/issues/2127