Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded styled-components to v4+ #12653

Merged
merged 2 commits into from
Apr 11, 2019

Conversation

abotteram
Copy link
Contributor

@abotteram abotteram commented Apr 11, 2019

Summary

This PR can be summarized in the following changelog entry:

  • Upgraded styled components to v4+.

Relevant technical choices:

Test instructions

This PR can be tested by following these steps:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended

Fixes #

…into upgrade-styled-components-to-v4

Conflicts:
	js/tests/components/__snapshots__/SnippetPreviewSection.test.js.snap
	js/tests/components/__snapshots__/UpsellBox.test.js.snap
	yarn.lock
Copy link
Member

@igorschoester igorschoester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR 👍

@igorschoester
Copy link
Member

Acceptance ✅

The failing Travis build is unrelated. Will fix in the release/11.0-schema branch if that still fails there.

@igorschoester igorschoester merged commit f2497cc into release/11.0-schema Apr 11, 2019
@igorschoester igorschoester deleted the upgrade-styled-components-to-v4 branch April 11, 2019 12:47
@igorschoester igorschoester added this to the 11.0 milestone Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants