fix: backport npm fetcher code #8
Conversation
Does fix multiple issues when trying to use npm fetcher with Node.js 16.X.X (current LTS) version in fetch and installation process. Using the backported version of current state from master.
|
@rpurdie Could you have a look? |
There was a problem hiding this comment.
Can you send this patch to openembedded-core@lists.openembedded.org
|
@kraj Why use this outdated and old method when there is Github? Why are all Linux-Guys are that special... |
There was recently a discussion on this. In summary there are reasons that the mailing list/patch workflow works better when you have a wide range of reviewers rather than the single maintainer model which github promotes and works best with. https://lists.openembedded.org/g/bitbake-devel/topic/bitbake_style_workflow/86911583 |
|
The patch needs to go to bitbake-devel. At a quick glance it also needs a proper commit message explaining what it does and why. It shouldn't mix whitespace changes with code changes either as it obscures what the patch is doing. |
|
@rpurdie I can just go with what the guy(s) already told in the discussion about plans switching to a Git-platform: It make things a lot easier and I would be a happy contributor if so. And regarding the whitespaces: This is the freaking PEP8 standard, my IDE does this right out of the box... (Sorry about madness, but I am just pissed of how hard a contribution could be!) |
|
@mxzinke it works two ways. I am frustrated people want us to destroy our existing ecosystem to meet these new needs. I see the value in new contributors but there is a high price which I don't think people see. |
Does fix multiple issues when trying to use npm fetcher with Node.js v16 LTS version in fetch and installation process. Using the backported version of the current state from master branch.