Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Housekeeping: update sdk, jamf client, terraform / unit test gh workflow #26

Merged
merged 8 commits into from
Mar 22, 2024

Conversation

w0de
Copy link
Collaborator

@w0de w0de commented Mar 22, 2024

This contains those changes from #21 which do propose questionable and/or breaking changes to the API (ie, no change to jamf_staticComputerGroup.computer.{serial_number,id}, plus some overdue dependency updates.

What's included:

  • Updates the go-jamf-api dependency to the latest version v0.0.0-20231020015325-f3a01d49ab57
  • Updates the terraform version used for tests to 1.6.5
  • Updates terraform-plugin-sdk to 2.16.0
  • Amends OAuth support to use go-jamf-api's WithOAuth option.
  • Amends func testAccPreCheck to require either OAuth or basic credentials, not both.
  • Adds a unit test workflow. (All tests are currently acc tests and so this will always pass if lint passes. For future use.)

Note that acceptance tests are still not passing. Rather than smush partial fixes into this delta, I've opened issues (#24, #25) and will tackle them in discrete PRs.

@w0de w0de requested a review from Yohan460 March 22, 2024 00:21
@w0de w0de merged commit 61adc65 into Yohan460:master Mar 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants