Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .NET Standard 2.0 support #112

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

bdovaz
Copy link

@bdovaz bdovaz commented Oct 17, 2021

  • Relevant csproj have been updated to sdk style format.
  • Remove code smells to relevant projects.
  • Apply code formatting to relevant projects.
  • Update *.sln to VS 2019.

They pass all tests perfectly.

I have not dared to eliminate the non-relevant projects but it would be necessary to make a good cleanup since possibly today having only one project (Rssdp.NetCore) that targets .NET Standard 2.0 would be enough.

@bdovaz
Copy link
Author

bdovaz commented Oct 17, 2021

@Yortw CI seems to be failing because it tries to download a non existing netfx_403mtpack.exe.

You should update CI to github actions and dotnet sdk as it's easier to maintain. I can help you with that.

But first we should remove the obsolete projects so it can be easier to integrate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant