Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

christopher/add fascn #605

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

christopher/add fascn #605

wants to merge 5 commits into from

Conversation

christopherL91
Copy link

  • Update documentation
  • Update typings
  • Add dependency bitarray for FASC-N
  • Add support for generating FASC-N
  • Add tests for FASC-N

@christopherL91
Copy link
Author

I found some typings errors in the code. I could move those commits out of this PR if you'd like.

@christopherL91
Copy link
Author

The module name is not set in stone, as there's already a piv.py it felt weird to have a module called the same. We could also discuss appropriate error handling and assertion that the lenght of each field are correct.

@christopherL91 christopherL91 force-pushed the christopher/add-fascn branch 2 times, most recently from f0a8087 to c73607c Compare March 12, 2024 13:35
@christopherL91 christopherL91 force-pushed the christopher/add-fascn branch 2 times, most recently from 0aa2a56 to 0a6157d Compare March 13, 2024 15:03
@christopherL91
Copy link
Author

@dainnilsson any updates to this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dainnilsson dainnilsson Awaiting requested review from dainnilsson

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@christopherL91