fix signed / unsigned comparison

YuriL180821 · Sep 25, 2022 · a69cca0 · a69cca0
1 parent 1d5208c
commit a69cca0
Showing 1 changed file with 9 additions and 7 deletions.
diff --git a/shell/browser/notifications/win/windows_toast_notification.cc b/shell/browser/notifications/win/windows_toast_notification.cc
@@ -1283,13 +1283,15 @@ class NotificationActivator final
     // SAP-15908 refine notification-activation for cold start
     if (dataCount) {
       stm << L"[";  // json array open brace
-      std::for_each(
-          data, data + dataCount,
-          [&](const NOTIFICATION_USER_INPUT_DATA& item) {
-            stm << item
-                // avoid problem with last delimeter
-                << std::wstring((&item - data + 1 == dataCount) ? L"" : L",");
-          });
+      std::for_each(data, data + dataCount,
+                    [&](const NOTIFICATION_USER_INPUT_DATA& item) {
+                      stm << item
+                          // avoid problem with last delimeter
+                          << std::wstring((static_cast<ULONG>(&item - data +
+                                                              1) == dataCount)
+                                              ? L""
+                                              : L",");
+                    });
       stm << L"]";  // json array close brace
     }
     auto* app = api::App::Get();