Merge pull request #173 from YusukeIwaki/porting/4993

feat: add custom debugging port option

lib/puppeteer/launcher/chrome.rb

@@ -34,7 +34,7 @@ def launch(options = {})
         if @launch_options.pipe?
           chrome_arguments << '--remote-debugging-pipe'
         else
-          chrome_arguments << '--remote-debugging-port=0'
+          chrome_arguments << "--remote-debugging-port=#{@chrome_arg_options.debugging_port}"
         end
       end
 

lib/puppeteer/launcher/chrome_arg_options.rb

@@ -34,9 +34,10 @@ def initialize(options)
       if @headless.nil?
         @headless = !@devtools
       end
+      @debugging_port = options[:debugging_port] || 0
     end
 
-    attr_reader :args, :user_data_dir
+    attr_reader :args, :user_data_dir, :debugging_port
 
     def headless?
       @headless

lib/puppeteer/launcher/firefox.rb

@@ -28,7 +28,7 @@ def launch(options = {})
         end
 
       if firefox_arguments.none? { |arg| arg.start_with?('--remote-debugging-') }
-        firefox_arguments << '--remote-debugging-port=0'
+        firefox_arguments << "--remote-debugging-port=#{@chrome_arg_options.debugging_port}"
       end
 
       temporary_user_data_dir = nil

lib/puppeteer/puppeteer.rb

@@ -44,6 +44,7 @@ def launch(
     args: nil,
     user_data_dir: nil,
     devtools: nil,
+    debugging_port: nil,
     headless: nil,
     ignore_https_errors: nil,
     default_viewport: NoViewport.new,
@@ -63,6 +64,7 @@ def launch(
       args: args,
       user_data_dir: user_data_dir,
       devtools: devtools,
+      debugging_port: debugging_port,
       headless: headless,
       ignore_https_errors: ignore_https_errors,
       default_viewport: default_viewport,

spec/integration/launcher_spec.rb

@@ -260,6 +260,16 @@
         expect(screenshot.size).to be > 50000
       end
     end
+
+    it 'should set the debugging port' do
+      options = default_launch_options.merge(
+        debugging_port: 9999,
+      )
+
+      Puppeteer.launch(**options) do |browser|
+        expect(URI(browser.ws_endpoint).port).to eq(9999)
+      end
+    end
   end
 
   describe 'Puppeteer#default_args', puppeteer: :browser do