Support OOP iframe #172
Support OOP iframe #172
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
spec/integration/oopif_spec.rb
Outdated
|
|
||
| it 'should track navigations within OOP iframes' do | ||
| page.goto(server_empty_page) | ||
| frame = page.wait_for_frame(predicate: -> (frame) { page.frames.index { |_frame| _frame == frame } == 1 }) do |
There was a problem hiding this comment.
Lint/ShadowingOuterLocalVariable: Shadowing outer local variable - frame.
spec/integration/oopif_spec.rb
Outdated
|
|
||
| it 'should support OOP iframes becoming normal iframes again' do | ||
| page.goto(server_empty_page) | ||
| frame = page.wait_for_frame(predicate: -> (frame) { page.frames.index { |_frame| _frame == frame } == 1 }) do |
There was a problem hiding this comment.
Lint/ShadowingOuterLocalVariable: Shadowing outer local variable - frame.
spec/integration/oopif_spec.rb
Outdated
|
|
||
| it 'should support OOP iframes getting detached' do | ||
| page.goto(server_empty_page) | ||
| frame = page.wait_for_frame(predicate: -> (frame) { page.frames.index { |_frame| _frame == frame } == 1 }) do |
There was a problem hiding this comment.
Lint/ShadowingOuterLocalVariable: Shadowing outer local variable - frame.
spec/integration/oopif_spec.rb
Outdated
|
|
||
| it 'should keep track of a frames OOP state' do | ||
| page.goto(server_empty_page) | ||
| frame = page.wait_for_frame(predicate: -> (frame) { page.frames.index { |_frame| _frame == frame } == 1 }) do |
There was a problem hiding this comment.
Lint/ShadowingOuterLocalVariable: Shadowing outer local variable - frame.
spec/integration/oopif_spec.rb
Outdated
|
|
||
| it 'should support evaluating in oop iframes' do | ||
| page.goto(server_empty_page) | ||
| frame = page.wait_for_frame(predicate: -> (frame) { page.frames.index { |_frame| _frame == frame } == 1 }) do |
There was a problem hiding this comment.
Lint/ShadowingOuterLocalVariable: Shadowing outer local variable - frame.
spec/integration/oopif_spec.rb
Outdated
|
|
||
| it 'should provide access to elements' do | ||
| page.goto(server_empty_page) | ||
| frame = page.wait_for_frame(predicate: -> (frame) { page.frames.index { |_frame| _frame == frame } == 1 }) do |
There was a problem hiding this comment.
Lint/ShadowingOuterLocalVariable: Shadowing outer local variable - frame.
spec/integration/oopif_spec.rb
Outdated
| end | ||
|
|
||
| it 'should report oopif frames' do | ||
| frame = page.wait_for_frame(predicate: -> (frame) { frame.url&.end_with?('/oopif.html') }) do |
There was a problem hiding this comment.
Lint/ShadowingOuterLocalVariable: Shadowing outer local variable - frame.
YusukeIwaki
force-pushed
the
porting/7556
branch
2 times, most recently
from
a219c6c
to
d894f63
Compare
YusukeIwaki
force-pushed
the
porting/7556
branch
3 times, most recently
from
da7e999
to
33deb65
Compare
YusukeIwaki
force-pushed
the
porting/7556
branch
from
a999d9c
to
6320878
Compare
ref: puppeteer/puppeteer#7556
refs #170