Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: forget queuedEventGroup when emitting response in responseReceivedExtraInfo #219

Merged
merged 1 commit into from May 9, 2022
Merged

fix: forget queuedEventGroup when emitting response in responseReceivedExtraInfo #219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/puppeteer/network_event_manager.rb
View file
Open in desktop
Expand Up @@ -119,4 +119,8 @@ def enqueue_event_group(network_request_id, queued_event_group)
def get_queued_event_group(network_request_id)
@queued_event_group_map[network_request_id]
end

def forget_queued_event_group(network_request_id)
@queued_event_group_map.delete(network_request_id)
end
end
1 change: 1 addition & 0 deletions lib/puppeteer/network_manager.rb
View file
Open in desktop
Expand Up @@ -395,6 +395,7 @@ def request_interception=(enabled)
# We may have skipped response and loading events because we didn't have
# this ExtraInfo event yet. If so, emit those events now.
if_present(@network_event_manager.get_queued_event_group(event['requestId'])) do |queued_events|
@network_event_manager.forget_queued_event_group(event['requestId'])
emit_response_event(queued_events.response_received_event, event)
if_present(queued_events.loading_finished_event) do |loading_finished_event|
emit_loading_finished(loading_finished_event)
Expand Down