Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add small improvements #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DeFuex
Copy link
Contributor

@DeFuex DeFuex commented Oct 1, 2020

  • Does add android ktx to use e.g: withStyledAttributes.
  • uses @jvmoverloads to hide all constructor calls and uses kotlins init {} function instead.
  • enable jvm 1.8 bytecode compilation target for withStyledAttributes function.

@DeFuex DeFuex marked this pull request as ready for review October 1, 2020 16:12
@YvesCheung
Copy link
Owner

Thanks for your contribution!
“Uses @jvmoverloads to hide all constructor calls and uses kotlins init {} function instead.” looks good.
However, I hesitate to use AndroidX and target jvm1.8, which might increase the threshold for users.
For now, There are still some old fat project using "support library" instead of "AndroidX".
A library should be able to adapt to as many development environments as possible.

@DeFuex
Copy link
Contributor Author

DeFuex commented Oct 10, 2020

Hi, no problem, i will change it to only use the Overload anmotation then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants