feature(rpc): add fixed values to getblocktemplate response

[oxarbitrage]

Motivation

Close #5452

Solution

Add constants where needed, get constant from other crates, update tests.

Review

Anyone can review.

Reviewer Checklist

• Will the PR name make sense to users?
  • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
• Are the PR labels correct?
• Does the code do what the ticket and PR says?
• How do you know it works? Does it have tests?

[codecov]

Codecov Report

Merging #5558 (100daa2) into main (75f83fc) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5558      +/-   ##
==========================================
+ Coverage   78.84%   78.87%   +0.02%     
==========================================
  Files         305      305              
  Lines       38126    38127       +1     
==========================================
+ Hits        30061    30071      +10     
+ Misses       8065     8056       -9     

[teor2345]

Thanks, looks good!

I have a suggestion in PR #5559, and it will help me to review if we add documentation for the new fields.

[teor2345]

@Mergifyio update

[mergify]

update

✅ Branch has been successfully updated

[teor2345]

@Mergifyio update

[mergify]

update

✅ Branch has been successfully updated

[teor2345]

This PR has conflicts with PR #5554, which just merged. So it will need to be rebased or it will need a merge commit.

[oxarbitrage]

The tests will fail because they all get into this code section

zebra/zebra-rpc/src/methods/get_block_template_rpcs.rs

Line 280 in 304048e

let coinbase_tx = if mempool_txs.is_empty() {

where everything is empty.

I am unsure if we should update the test and snapshots to be empty or if we should add the fixed values into that code as well.

[teor2345]

The tests will fail because they all get into this code section

zebra/zebra-rpc/src/methods/get_block_template_rpcs.rs

Line 280 in 304048e

let coinbase_tx = if mempool_txs.is_empty() {

where everything is empty.

I am unsure if we should update the test and snapshots to be empty or if we should add the fixed values into that code as well.

That code disappears in my next PR #5580, so you could base this PR on that one, or copy the fixed values into the code that is about to be deleted?

[teor2345]

Thanks, looks good!