Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump regex from 1.8.4 to 1.9.1 #7189

Merged
merged 1 commit into from Jul 12, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 10, 2023

Depends-On: #7158

Bumps regex from 1.8.4 to 1.9.1.

Changelog

Sourced from regex's changelog.

1.9.1 (2023-07-07)

This is a patch release which fixes a memory usage regression. In the regex 1.9 release, one of the internal engines used a more aggressive allocation strategy than what was done previously. This patch release reverts to the prior on-demand strategy.

Bug fixes:

1.9.0 (2023-07-05)

This release marks the end of a years long rewrite of the regex crate internals. Since this is such a big release, please report any issues or regressions you find. We would also love to hear about improvements as well.

In addition to many internal improvements that should hopefully result in "my regex searches are faster," there have also been a few API additions:

  • A new Captures::extract method for quickly accessing the substrings that match each capture group in a regex.
  • A new inline flag, R, which enables CRLF mode. This makes . match any Unicode scalar value except for \r and \n, and also makes (?m:^) and (?m:$) match after and before both \r and \n, respectively, but never between a \r and \n.
  • RegexBuilder::line_terminator was added to further customize the line terminator used by (?m:^) and (?m:$) to be any arbitrary byte.
  • The std Cargo feature is now actually optional. That is, the regex crate can be used without the standard library.
  • Because regex 1.9 may make binary size and compile times even worse, a new experimental crate called regex-lite has been published. It prioritizes binary size and compile times over functionality (like Unicode) and performance. It shares no code with the regex crate.

New features:

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually

@dependabot dependabot bot requested review from a team as code owners July 10, 2023 02:37
@dependabot dependabot bot requested review from upbqdn and removed request for a team July 10, 2023 02:37
@dependabot dependabot bot added A-dependencies Area: Dependency file updates A-rust Area: Updates to Rust code C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG P-Low ❄️ labels Jul 10, 2023
@dependabot dependabot bot force-pushed the dependabot/cargo/regex-1.9.1 branch from 0558018 to 73a40bb Compare July 10, 2023 03:38
@teor2345 teor2345 added extra-reviews This PR needs at least 2 reviews to merge do-not-merge Tells Mergify not to merge this PR labels Jul 10, 2023
@teor2345 teor2345 removed the request for review from a team July 10, 2023 06:40
@teor2345 teor2345 removed the do-not-merge Tells Mergify not to merge this PR label Jul 10, 2023
@teor2345
Copy link
Contributor

This is a complete rewrite of the regex engine, that's already had one patch release:
rust-lang/regex#1027 (comment)

Should we merge it now, so it gets a lot of testing before the release?
Or should we wait a while and see if any more bugs are fixed?

(I've already marked it as needing 2 reviews, seems sensible. Although I don't think we can review the whole engine rewrite in any meaningful way. Fortunately we don't use regex for consensus-critical checks.)

Bumps [regex](https://github.com/rust-lang/regex) from 1.8.4 to 1.9.1.
- [Release notes](https://github.com/rust-lang/regex/releases)
- [Changelog](https://github.com/rust-lang/regex/blob/master/CHANGELOG.md)
- [Commits](rust-lang/regex@1.8.4...1.9.1)

---
updated-dependencies:
- dependency-name: regex
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/cargo/regex-1.9.1 branch from 73a40bb to 2b36f91 Compare July 10, 2023 08:28
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, it's a large rewrite, but we don't use it for anything consensus-critical.

@teor2345 teor2345 removed the extra-reviews This PR needs at least 2 reviews to merge label Jul 12, 2023
@teor2345
Copy link
Contributor

Let's try this and see how it goes?

@teor2345
Copy link
Contributor

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Jul 12, 2023

refresh

✅ Pull request refreshed

mergify bot added a commit that referenced this pull request Jul 12, 2023
mergify bot added a commit that referenced this pull request Jul 12, 2023
@teor2345
Copy link
Contributor

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Jul 12, 2023

refresh

✅ Pull request refreshed

mergify bot added a commit that referenced this pull request Jul 12, 2023
@mergify mergify bot merged commit 7f3a4e9 into main Jul 12, 2023
275 checks passed
@mergify mergify bot deleted the dependabot/cargo/regex-1.9.1 branch July 12, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dependencies Area: Dependency file updates A-rust Area: Updates to Rust code C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant