Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bracket name fix #5145

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from
Draft

Bracket name fix #5145

wants to merge 4 commits into from

Conversation

Wei-whey-way
Copy link

Description

We plan to fix the issue mentioned in #3825, on 64 bits windows 11. We are attempting to identify why the bracket character breaks the link.

Changes

No changes at the moment. We created a branch from the development branch called bracket_name_fix.

Additional information

This pull request is a placeholder for further updates.

Tested on: <!-- OS including version ->

Wei-whey-way and others added 2 commits May 7, 2024 15:24
@Wei-whey-way @nathanlesage @actions-user
Sync with main repo (#1)
c90d2f8 
* chore: Add Sponsors link

* fix: Autocorrect entries

Fixes Zettlr#4961

* fix: i18n process

* No more file name/message duplication
* Retain relative Vue-path for better file identification in PO files
* Improved extraction regex to properly extract script tags
* Add a run of msguniq over each file to remove potential duplicates

Fixes Zettlr#5122

* fix: Re-run i18n extraction script to fix loads of duplications and other issues

* chore: Update changelog

* chore: Fix German (de-DE) translation

* chore: Bump version to 3.1.0-beta.3

* chore: Fix spelling in Changelog

* Update CITATION.cff

* fix: Improve logging in event merger

* fix: Weird bug in Nextcloud

* Update CITATION.cff

* fix: Prevent applying illogical updates on file trees

* refactor: Improve types

* chore: Bump Codemirror dependencies to newest versions

* chore: Bump Electron to v30.0.1

* chore: Upgrade ESLint and fix new linter errors

* chore: Bump eslint dependencies

* chore: Upgrade a last set of dependencies

* chore: Bump remark deps

* chore: Clean up CHANGELOG, Electron to 30.0.2

* chore: Bump Electron 30.0.1 -> 3.0.2

* chore: Bump version to 3.1.0; update changelog

* Update CITATION.cff

* chore: Add missing paragraph to changelog

* chore: Bump version to 3.1.0; update changelog

* chore: Add missing paragraph to changelog

* chore: Downgrade Electron to 29.3.2

See issue Zettlr#5135

* chore: Fix changelog

* chore: Bump version to 3.1.1

* chore(citeproc): Update CSL files

* Update CITATION.cff

---------

Co-authored-by: Hendrik Erz <hendrik@zettlr.com>
Co-authored-by: GitHub Action <action@github.com>
@Wei-whey-way
Merge branch 'Zettlr:develop' into develop
105fe66
@boring-cyborg boring-cyborg
Copy link

boring-cyborg bot commented May 7, 2024

Thank you for opening your first PR! 🎉 We are very happy and would like to thank you very much for your contribution. If everything checks out, we'll make sure to review the PR as soon as possible and give feedback. In the meantime, to make the reviewing process as fast as possible, you can help us by checking the following things:

  • Did you follow the JSStandard coding style? - Did you comment everywhere where the necessity of a piece of code or the
    way it was implemented is not immediately obvious?
  • Did you attempt to stick as much to current coding habits as possible?
    (Note that this does not apply to pieces of code where we ourselves
    obviously violated good coding practices, which unfortunately happens
    sometimes. But please indicate this in your PR so that we know what you
    rectified!)

Furthermore, make sure that the linter does not complain, which will check your code on every new commit. If the linter task fails, make sure to run yarn lint locally and check the file eslint_report.htm which will tell you precisely what went wrong.
Stay sharp, and thanks again!

@nathanlesage
Copy link
Member

No changes at the moment. We created a branch from the development branch called bracket_name_fix.

Could you then please convert this into a draft PR so that it's easier to see that this is currently work in progress? Thanks.

@Wei-whey-way Wei-whey-way marked this pull request as draft May 9, 2024 03:34
@Wei-whey-way
Copy link
Author

Thanks for the heads up, issue has been converted to a draft PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Wei-whey-way @nathanlesage @khksamuel