Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: for #597 #598

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: for #597 #598

wants to merge 2 commits into from

Conversation

DickSmith
Copy link

@DickSmith DickSmith commented Feb 15, 2019

fix: for #597
I assume it was intended to add *.min.js to the .gitignore rather than the .npmignore

@wolthers
Copy link

Any update? This is breaking pretty much all consumers of your module.

@aFarkas
Copy link
Owner

aFarkas commented Mar 11, 2019

Sorry but it was intended to remove the min file from npm. If you have a build process you are minifying your scripts yourself. And you should always require the lazysizes file not *.min.js.

On the other hand it is pretty obvious that the min files need to exist on gituhb because they are linked on multiple sites and there is also no build process behind it.

The reasoning behind this change can be found here. I'm very sorry to cause you those problems and I should have known better and changed the version number accordingly. (It was a breaking change). From my standpoint you should not require the min version and I doubt that many people are doing it.

Question: How does your require call look like? Do you know a better way to workaround the described issue? At the end it should be easy to fix your require calls instead.

@ldu1991
Copy link

ldu1991 commented Mar 20, 2019

Hello!
I use .min.js on the site, my hool transfers all .min.js and .min.css to the vendor folder for each plug-in, and for convenience I need minified files. Just all plug-ins have minified files, and I think that those who don’t need min files can use complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants