Remove all user account features #1338
Conversation
|
Ain't GUILD_SYNC a legacy user implementation as well in shard? |
|
you left some interfaces dangling around ( And some very old bots can technically be in Group Channels iirc, I assume we aren't considering that as a valid enough reason to keep the around though (made a pr, bsian03#21) |
|
|
|
I'm in the process of going through all of them now that I'm on my laptop |
|
More things I've just found, the event definitions for |
Removals: - abalabahaha/eris#1283 - abalabahaha/eris#1285 - abalabahaha/eris#1369 Additions: - abalabahaha/eris#494 - abalabahaha/eris#1193 - abalabahaha/eris#1338 - abalabahaha/eris#1386
|
you may aswell want to remove the hit property from Message, as it is meant for a user-only search feature |
| : CH extends Extract<InviteChannel, GroupChannel> // Invite without Metadata | ||
| ? never // If the channel is GroupChannel, there is no guild | ||
| : CH extends Exclude<InviteChannel, InvitePartialChannel> // Invite without Metadata and not GroupChanel | ||
| ? Guild // If the invite channel is not partial | ||
| : Guild | undefined; // If the invite channel is partial |
There was a problem hiding this comment.
Bots can still fetch group invites
There was a problem hiding this comment.
Can probably just type this as InvitePartial in that case
There was a problem hiding this comment.
Wait, is this not the correct behaviour anyways? We could check for channel type but that causes more headaches for not much profit
| @@ -70,7 +70,7 @@ converterCommand.pickCommand = function pickCommand() { | |||
| * @prop {Number} current.pausedTimestamp The timestamp of the most recent pause | |||
| * @prop {Number} current.playTime How long the current stream has been playing for, in milliseconds | |||
| * @prop {Number} current.startTime The timestamp of the start of the current stream | |||
| * @prop {String} id The ID of the voice connection (guild ID) | |||
There was a problem hiding this comment.
having (guild ID) in parenthesis seems clearer than "the guild id of the voice connection"
|
I've gone back through some documentation, and now see that GroupChannels are not purely userbot features. #1406 properly implements the official api methods for them. |
Bots can not join group channels anymore though, some bots may still be in one because it was possible in the past. But they do not receive any messages. |
|
I didn't say they could join them, they can't be received over the gateway sure but they can be retrieved from rest just fine if the bot created it |
|
Don't think it's worth maintaining/keeping in Eris. The % of bots having continuous access to group channels is miniscule, if anything |
No description provided.