-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attachment type #1358
base: dev
Are you sure you want to change the base?
Attachment type #1358
Conversation
Is this solely for the attachment type? There is also an attachments map in command interaction. |
…hments in CommandInteraction's constructor
@Linker-123 Is that better? |
Add types for attachment class |
- rename "main" to "upstream" - add "everything-v10" branch Additions: - abalabahaha/eris#1283 - abalabahaha/eris#1285 - abalabahaha/eris#1332 - abalabahaha/eris#1344 - abalabahaha/eris#1351 - abalabahaha/eris#1355 - abalabahaha/eris#1358 - abalabahaha/eris#1359 - abalabahaha/eris#1363 - abalabahaha/eris#1366 - abalabahaha/eris#1367 - abalabahaha/eris#1368 - abalabahaha/eris#1369 - abalabahaha/eris#1370 Removals: - abalabahaha/eris#1305 - abalabahaha/eris#1314 - abalabahaha/eris#1325
Co-authored-by: Donovan Daniels <hewwo@yiff.rocks>
Co-authored-by: TTtie <me@tttie.cz>
what was the conclusion with the attachments class vs just using objects? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sort properties alphabetically
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The interface pre-dates this pr. Before I headed away I was considering merging it but that would mean processing the message to create attachment classes for each attachment |
That sounds like the best idea it's either that or rename one of them |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
URL
is used everywhere else, not Url
Co-authored-by: bsian03 <chharry321@gmail.com>
# Conflicts: # esm.mjs # index.d.ts # index.js # lib/structures/AutocompleteInteraction.js # lib/structures/CommandInteraction.js # lib/structures/ComponentInteraction.js
* @prop {String?} guildID The ID of the guild in which the interaction was created | ||
* @prop {Member?} member The member who triggered the interaction (This is only sent when the interaction is invoked within a guild) | ||
* @prop {User?} user The user who triggered the interaction (This is only sent when the interaction is invoked within a dm) | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this sorted in a recent PR and I've unsorted it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
No description provided.