fix(voice): OggOpusTransformer missing callback in _final #1505
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered this when I tried to increase
voiceDataTimeout
and noticed theend
event was later than expected.Because the stream does not emit
end
, it will stop playing after waiting for timeout, not when the file ends.ref: https://nodejs.org/docs/latest-v20.x/api/stream.html#writable_finalcallback