PR for code review #1
Conversation
There was a problem hiding this comment.
I have to read up on Unity and the UnityPackages. It doesn't feel completely right that dlls require to be added to the repo like this. Usually dependencies are added to the project file (csproj) and restored (downloaded) when a build is done. Is there no csproj file for this project?
It mostly my unfamiliarity with Unity that confuses me and not your code though! :D
Could you update the README with some instructions how to get things running locally?
| public class AblyManagerBehavior : MonoBehaviour | ||
| { | ||
| private AblyRealtime realtime = new AblyRealtime( | ||
| new ClientOptions { Key = "INSERT_YOUR_ABLY_API_KEY_HERE" } |
There was a problem hiding this comment.
Does Unity allow to read env variables using System.Environment.GetEnvironmentVariable()? Usually keys/secrets are in settings files (json) which are read via System.Environment.GetEnvironmentVariable(). The json files themselves can be gitignored.
No description provided.