* swiper.el: make line numbers consistent with display-line-numbers-mode #2731
Conversation
mitch-kyle
force-pushed
the
master
branch
2 times, most recently
from
f24e15c
to
d2f7569
Compare
mitch-kyle
force-pushed
the
master
branch
2 times, most recently
from
d365f81
to
7442102
Compare
There was a problem hiding this comment.
LGTM apart from some minor nits/questions.
I'm not sure if this change is small enough to be merged without a copyright assignment, though. Do you already have one on file with the FSF? If not, would you be willing to? If you're not familiar with it, there's some more information at (info "(emacs) Copyright Assignment").
I don't but I'm willing to. I'll let you know when the paperwork goes through |
Three changes were made to the 'swiper' line numbers to make it more
like the builtin 'display-line-numbers-mode'
1. The line numbers are now right justified
see: 'swiper--candidates'
2. The line numbers now have custom faces based on the builtin
line-number and line-number-current-line faces
see: 'swiper-line-number-face'
'swiper-current-line-number-face'
3. The current line number is highlighted. using an ivy format
function
see 'swiper--format-function'
These changes are what came from me investigating how to change
the appearance of the swiper line numbers. This change should add
some customization support for swiper line numbers using the builtin
display-line-numbers-modeas "sane default"Three changes were made:
The line numbers are now right justified.
see:
swiper--candidatesThe line numbers now have custom faces based on the builtin
line-number and line-number-current-line faces.
see:
swiper-line-number-faceswiper-current-line-number-faceThe current line number is highlighted. using an ivy format
function.
see:
swiper--format-function