Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reabsorb ivy-avy into ivy #2917

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Reabsorb ivy-avy into ivy #2917

wants to merge 1 commit into from

Conversation

basil-conto
Copy link
Collaborator

For some discussion, see the following threads:
https://lists.gnu.org/r/emacs-devel/2021-02/msg01935.html
https://lists.gnu.org/r/emacs-devel/2021-03/msg00490.html

  • ivy-avy.el: Move contents to ivy.el. Bump package versions to 0.13.5. Mention deprecation in Commentary and warning message.

  • ivy.el: Bump package version to 0.13.5.
    (ivy-define-key): Use function-put in place of put.
    (ivy-minibuffer-map): Bind ivy-avy.
    (ivy-avy-style): Moved from ivy-avy.el. Add a nil option for falling through to the default avy-styles-alist or avy-style.
    (ivy--avy-candidates, ivy--avy-action, ivy--avy-handler-function)
    (ivy-avy): Moved from ivy-avy.el with some cleanups.

  • swiper.el: Bump package versions to 0.13.5. Localize external variable and function declarations.
    (swiper-avy): Fix error message and docstring.

  • counsel.el:

  • ivy-hydra.el:

  • doc/ivy.org: Bump package versions to 0.13.5.

  • doc/ivy.texi: Regenerate.

  • Makefile (compile): Don't byte-compile ivy-avy.el.

  • ivy-test.el (ivy-avy):

  • targets/plain.el: Don't load ivy-avy.el.

Closes #2574, closes #2583.

@basil-conto basil-conto added regression admin Related to project management downstream Issue lies with downstream package compat Issues relating to backward/forward compatibility labels Sep 22, 2021
@basil-conto basil-conto self-assigned this Sep 22, 2021
For some discussion, see the following threads:
https://lists.gnu.org/r/emacs-devel/2021-02/msg01935.html
https://lists.gnu.org/r/emacs-devel/2021-03/msg00490.html

* ivy-avy.el: Move contents to ivy.el.  Bump package versions to
0.13.5.  Mention deprecation in Commentary and warning message.

* ivy.el: Bump package version to 0.13.5.
(ivy-define-key): Use function-put in place of put.
(ivy-minibuffer-map): Bind ivy-avy.
(ivy-avy-style): Moved from ivy-avy.el.  Add a nil option for
falling through to the default avy-styles-alist or avy-style.
(ivy--avy-candidates, ivy--avy-action, ivy--avy-handler-function)
(ivy-avy): Moved from ivy-avy.el with some cleanups.

* swiper.el: Bump package versions to 0.13.5.
Localize external variable and function declarations.
(swiper-avy): Fix error message and docstring.

* counsel.el:
* ivy-hydra.el
* doc/ivy.org: Bump package versions to 0.13.5.
* doc/ivy.texi: Regenerate.

* Makefile (compile): Don't byte-compile ivy-avy.el.
* ivy-test.el (ivy-avy):
* targets/plain.el: Don't load ivy-avy.el.

Closes #2574, closes #2583.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin Related to project management compat Issues relating to backward/forward compatibility downstream Issue lies with downstream package regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'make compile' fails Why is ivy-avy.el not byte-compiled?
1 participant