Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve demo and hover rendering #87

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

acao
Copy link
Owner

@acao acao commented Feb 24, 2024

  • finish the reorg @imolorhe started - consistent file names, move features to features directory
  • switch to nodeResolution: bundler for esm, get rid of .js imports but still something newer than Node. keep nodeResolution: Node for cjs
  • fix some issues with hover rendering, add hover rendering of $ref pointers! (see image)
  • demo improvements - persist the edited values, use shema cache, remember the chosen schema, and change the headers based on the chosen schema (going to improve this further)
    image

Copy link

changeset-bot bot commented Feb 24, 2024

⚠️ No Changeset found

Latest commit: b149588

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Feb 24, 2024

Deploy Preview for codemirror-json-schema failed.

Name Link
🔨 Latest commit b149588
🔍 Latest deploy log https://app.netlify.com/sites/codemirror-json-schema/deploys/65da1b2749831b0008d67906

Copy link
Collaborator

@imolorhe imolorhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure changing the module resolution wouldn't reintroduce issues? I see that we are removing the ".je" suffix which was added when fixing a reported issue with resolving the module

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants