Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple functionality #10

Closed
wants to merge 17 commits into from
Closed

Multiple functionality #10

wants to merge 17 commits into from

Conversation

Kostanos
Copy link
Contributor

  1. Skip queries if pgRestifyResponseBody is not empty (in every request, not only on getList)
  2. Access parent object to get access to parent helpers like: convertColumnsToFields and others
  3. Return info after POST or PUT

@coveralls
Copy link

coveralls commented Oct 26, 2017

Coverage Status

Coverage decreased (-3.4%) to 95.904% when pulling 55e4275 on Kostanos:master into 69c46aa on acarl:master.

@Kostanos
Copy link
Contributor Author

Hi, I've creates again the PR you closed.
Check my comments about parent access, return value on insert/update
also I added on every request the verification if pre-hook already added some content to body

@acarl
Copy link
Owner

acarl commented Oct 29, 2017

Please separate these into a pull request per feature change. At this point it would probably be easier for you to clone the repository again to avoid the current multiple commits. Ideally there would be a single commit for each change.

You also did not address fixing the test cases.

Look at some other repositories for examples of pull requests. There are some good examples in the pg repository like the following.
brianc/node-postgres#1448

@acarl acarl closed this Oct 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants