Skip to content

Commit

Permalink
Merge pull request #2410 from pqarmitage/updates
Browse files Browse the repository at this point in the history
ipvs: Fix stats handling when only have 32 bit stats
  • Loading branch information
pqarmitage committed Apr 29, 2024
2 parents 722a9b0 + 4d13346 commit 556dd8b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 9 deletions.
4 changes: 2 additions & 2 deletions doc/man/man5/keepalived.conf.5.in
Original file line number Diff line number Diff line change
Expand Up @@ -681,8 +681,8 @@ possibly following any cleanup actions needed.
# When SNMP requests are made, the checker process only updates the
# virtual and real server stats from the kernel if the last time the
# stats for that virtual server were read was more than this configured
# interval. The default interval is 5 seconds, and the valid range is
# 1 milli-second to 30 seconds.
# interval (in seconds). The default interval is 5 seconds, and the
# valid range is 0.001 (1 milli-second) to 30 seconds.
\fBsnmp_vs_stats_update_interval\fR <TIMER>

# Like snmp_vs_stats_update_interval but for real servers. Stats for
Expand Down
8 changes: 1 addition & 7 deletions keepalived/check/libipvs.c
Original file line number Diff line number Diff line change
Expand Up @@ -961,7 +961,7 @@ static int ipvs_services_parse_cb(struct nl_msg *msg, void *arg)
} else if (svc_attrs[IPVS_SVC_ATTR_STATS])
#endif
{
if (ipvs_parse_stats64(&(get->user.entrytable[0].ip_vs_stats),
if (ipvs_parse_stats(&(get->user.entrytable[0].ip_vs_stats),
svc_attrs[IPVS_SVC_ATTR_STATS]) != 0)
return -1;
}
Expand All @@ -970,12 +970,6 @@ static int ipvs_services_parse_cb(struct nl_msg *msg, void *arg)

get->user.num_services++;

#if 0
get = REALLOC(get, sizeof(*get)
+ sizeof(ipvs_service_entry_t) * (get->user.num_services + 1));
*getp = get;
#endif

return 0;
}

Expand Down

0 comments on commit 556dd8b

Please sign in to comment.