vrrp: remove logging on status output #2411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A message is output to the log each time the status is queried. This is not necessary and can therefore be omitted. Signed-off-by: Florian Eckert <fe@dev.tdt.de>
|
@feckert Many thanks for you patch. I guess the log message was a hang over from when the JSON functionality developed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am the maintainer of the keepalived packages in OpenWrt.
There is also a LuCI frontend that queries the status of keepalived.
To get the status of keepalived, the json signal handling is used.
The problem now is, that when the LuCI status page is open in the browser, this removed message in the PR is show every 3 second on status query. In my opinion, this floods the log and is not necessary.