Add Misc Items from @voiperr

[thojkooi]

Original PR acemod/ACE3#2324

[thojkooi]

I've removed items such as bandage, blood bag, defib, pain killers etc from the original PR. This is done to avoid confusion with those items because they have no functionality and sound like they could be used for medical.

I would appriciate some more eyes over the entire list and spot anything that could potentially be confused for an item that has functionality within ACE or something that is already done in one of the existing modules.

[BaerMitUmlaut]

The following items could be confusing:

• Mobile phone (old and new) could be confusing because ACE Explosives has a mobile phone as a trigger
• Plastic water bottle, food cans etc. could be confused as consumable when the field rations get ported
• Pliers could be confused with wirecutter
• Battery could be confused with UAV battery
• Duct tape could be used for restraining captives
• Shovel could be used instead of the entrenching tool
• Any kind of map should give you access to the in-game map

[jonpas]

• QPATHTOF instead of unquoted PATHTOF
• Quotes "" instead of macro QUOTE when doing absolute references

I'd just remove those that could be confusing at any time.

[654wak654]

Glowbal did you check any of the new misc objects added with 1.76?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[jonpas]

I'd like to get this merged soon.

As for confusing items, I wouldn't mind if we'd suffix them all with something (maybe [Prop] as it corresponds to the tooltip? [Unusable or [Decor]?).

[dedmen]

This is basically all copy-paste. How about using macros?
Maybe X-Macros.

//classname, displayname
#define ITEMS(XX) \
 XX(Item_FMRadio, CSTRING(FMRadio)) \
 XX(Item_ExtensionCord, CSTRING(ExtensionCord)) \

#define DEFINE_ITEM_VEHICLECLASS(classname, displayN) \
class TRIPLES(ACEX,classname,Item) : ACEX_MiscItem_F { \
    scope = 2; \
    scopeCurator = 2; \
    displayName = displayN; \
    author = ACECSTRING(common,ACETeam); \
    vehicleClass = "ACE_Misc_Items"; \
    class TransportItems { \
        class DOUBLES(ACEX,classname) { \
            name = QUOTE(DOUBLES(ACEX,classname)); \
            count = 1; \
        }; \
    }; \
};

Can also combine that with CfgWeapons by adding model path and icon and such.

//classname, displayname, description, modelpath, picturepath, mass
#define ITEMS(XX) \
 XX(Item_FMRadio, CSTRING(FMRadio), CSTRING(Prop), "a3\structures_f\Items\Electronics\FMradio_F.p3d", 20) \
 XX(Item_ExtensionCord, CSTRING(ExtensionCord), CSTRING(Prop), "a3\structures_f\Items\Electronics\ExtensionCord_F.p3d", 20) \

#define DEFINE_ITEM_WEAPONCLASS(classname, displayN, description, modelpath, picturepath, itemMass) \
class TRIPLES(ACEX,classname,Item) : ACE_ItemCore  { \
    scope = 2; \
    displayName = displayN; \
    descriptionShort = description; \
    author = ACECSTRING(common,ACETeam); \
    model = modelpath; \
    picture = picturepath; \
    class ItemInfo: CBA_MiscItem_ItemInfo { \
        mass = itemMass; \
    }; \
};

End result would be
CfgWeapons.hpp:

#include "..."
ITEMS(DEFINE_ITEM_WEAPONCLASS)

CfgVehicles.hpp:

#include "..."
ITEMS(DEFINE_ITEM_VEHICLECLASS)

[dedmen]

Why is this being re-set in every subclass? It's already set to this in parent.