Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eslint 8 update #38

Merged
merged 9 commits into from Oct 20, 2021
Merged

Eslint 8 update #38

merged 9 commits into from Oct 20, 2021

Conversation

tomislav-s
Copy link
Contributor

  • Updates eslint and all related packages
  • Updates some code changes reported after npx run lerna test

@tomislav-s
Copy link
Contributor Author

Just noticed on other repos that the latest version of eslint-plugin-import is broken, see import-js/eslint-plugin-import#2255 and related PR import-js/eslint-plugin-import#2257 - best to not merge this PR until this is resolved

@tomislav-s
Copy link
Contributor Author

Just noticed on other repos that the latest version of eslint-plugin-import is broken, see import-js/eslint-plugin-import#2255 and related PR import-js/eslint-plugin-import#2257 - best to not merge this PR until this is resolved

This has now been updated

@heldinz
Copy link
Contributor

heldinz commented Oct 13, 2021

@tomislav-s Know any good way to test this? 😬

@tomislav-s
Copy link
Contributor Author

tomislav-s commented Oct 13, 2021

@tomislav-s Know any good way to test this? 😬

The simplest way is to run npx lerna run test which will run npm test in all packages, other than that not sure how to test with project code, sry 😬

Copy link
Contributor

@heldinz heldinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting a couple of errors when running all tests:

lerna ERR! npm run test exited 1 in '@acolorbright/eslint-config-ts-react'
lerna ERR! npm run test stdout:

> @acolorbright/eslint-config-ts-react@2.2.0 test
> eslint .


/Users/alice/Projects/ACB/acb-tools-and-configs/packages/eslint-config-ts-react/rules/react.js
  3:23  error  Replace `⏎··require('@acolorbright/eslint-config-ts/rules/style')` with `·require('@acolorbright/eslint-config-ts/rules/style')⏎··`  prettier/prettier

✖ 1 problem (1 error, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.

lerna ERR! npm run test stderr:
Warning: React version was set to "detect" in eslint-plugin-react settings, but the "react" package is not installed. Assuming latest React version for linting.
lerna ERR! npm run test exited 1 in '@acolorbright/eslint-config-ts-react'

Copy link
Contributor

@heldinz heldinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞🏻

@tomislav-s tomislav-s merged commit fdf70a9 into main Oct 20, 2021
@tomislav-s tomislav-s deleted the eslint-8-update branch October 20, 2021 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants