Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #2093: Replace Drush assume with no-interaction. #2150

Merged
merged 3 commits into from
Oct 28, 2017
Merged

Issue #2093: Replace Drush assume with no-interaction. #2150

merged 3 commits into from
Oct 28, 2017

Conversation

danepowell
Copy link
Contributor

Fixes #2093

@danepowell
Copy link
Contributor Author

Hmm. Apparently the default non-interactive response for drush si is no, which is problematic. We need a way to force site install non-interactively.

This is also confusing because I thought --yes and --no-interaction were equivalent in Drush 9. So I'm not sure why this PR would break tests. Seems like an undocumented "feature".

@grasmash
Copy link
Contributor

Yeah I noticed some quirks when I was working on this issue, they don't appear to be equivalent.

@danepowell danepowell mentioned this pull request Oct 19, 2017
Closed
@danepowell
Copy link
Contributor Author

This is blocked on drush-ops/drush#3082

@danepowell
Copy link
Contributor Author

New upstream issue: drush-ops/drush#3084

It sounds like Drush is actually going to preserve --yes and --no, along with --no-interaction, I'm just trying to confirm. So we'll have to think more carefully about which of the three options to use.

@danepowell
Copy link
Contributor Author

We should be able to use --no-interaction for site installs in Drush 9 beta8

@danepowell danepowell merged commit 145311c into acquia:9.1.x Oct 28, 2017
@danepowell danepowell deleted the issue-2093 branch December 6, 2017 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danepowell @grasmash