Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add exclude-labels for query issues #74

Merged
merged 4 commits into from Aug 9, 2021
Merged

feat: add exclude-labels for query issues #74

merged 4 commits into from Aug 9, 2021

Conversation

xrkffgg
Copy link
Member

@xrkffgg xrkffgg commented Aug 8, 2021

🤔 这个变动的性质是?/ What is the nature of this change?

  • 新特性提交 / New feature
  • bug 修复 / Fix bug
  • 样式优化 / Style optimization
  • 代码风格优化 / Code style optimization
  • 性能优化 / Performance optimization
  • 构建优化 / Build optimization
  • 网站、文档、Demo 改进 / Website, documentation, demo improvements
  • 重构代码或样式 / Refactor code or style
  • 测试相关 / Test related
  • 其他 / Other

🔗 相关 Issue / Related Issue

close #73

💡 需求背景和解决方案 / Background or solution

📝 更新日志 / Changelog

Language Changelog
🇨🇳 Chinese 查询 issues 新增 exclude-labels 查询条件。
支持的功能有 check-inactive close-issues lock-issues

@github-actions
Copy link

github-actions bot commented Aug 8, 2021

🎊 PR Preview has been successfully built and deployed to https://issues-helper-preview-pr-74.surge.sh

@xrkffgg xrkffgg requested a review from ajuner August 9, 2021 05:50
@xrkffgg xrkffgg merged commit b64d6e4 into main Aug 9, 2021
@xrkffgg xrkffgg deleted the k branch August 9, 2021 11:18
@@ -58,6 +69,13 @@ async function doQueryIssues(owner, repo, labels, state, creator) {
* You can identify pull requests by the pull_request key.
*/
if (a && b && iss.pull_request === undefined) {
if (excludeLabels) {
const labels = dealStringToArr(excludeLabels);
Copy link
Member

@meteorlxy meteorlxy Aug 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The result of dealStringToArr(excludeLabels) could be extracted to outer scope.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR welcome ~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Question] Is it possible to exclude issues with some labels when check-inactive ?
2 participants