feat: support default issueNumber get from context #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 PR Preview has been successfully built and deployed to https://issues-helper-preview-pr-81.surge.sh
|
meteorlxy
reviewed
Aug 13, 2021
Comment on lines
+71
to
+73
| if (ctx.eventName === 'issues') defaultNo = ctx.payload.issue.number; | ||
|
|
||
| const issueNumber = core.getInput('issue-number') || defaultNo; |
There was a problem hiding this comment.
Maybe we could use optional chaining here? (Not sure if it's supported in github actions)
const issueNumber = core.getInput('issue-number') || ctx.payload?.issue?.number;There was a problem hiding this comment.
node 12 does not support
Amour1688
approved these changes
Aug 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个变动的性质是？/ What is the nature of this change?
🔗 相关 Issue / Related Issue
💡 需求背景和解决方案 / Background or solution
📝 更新日志 / Changelog
issue-numbersupports getting from the context by defaultissue-number支持默认从 context 中获取