Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert compression changes related to windows but keep version logging #1049

Merged
merged 2 commits into from
Dec 27, 2022

Conversation

Phantsure
Copy link
Contributor

@Phantsure Phantsure commented Dec 27, 2022

due to symlink issues

Description

Revert compression changes related to windows but keep version logging

Motivation and Context

Some issues have been reported due to linux/mac cache not being recovered on windows because of symlink issue. We would be testing possible solutions for them till then reverting this change.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (add or update README or docs)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sorry, something went wrong.

@Phantsure Phantsure requested a review from a team as a code owner December 27, 2022 10:43
@github-actions github-actions bot requested a review from tanuj077 December 27, 2022 10:43
@Phantsure Phantsure requested a review from lvpx December 27, 2022 10:44

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Contributor

@lvpx lvpx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Phantsure Phantsure merged commit 4723a57 into main Dec 27, 2022
Dakshjain1 pushed a commit to SvavaCapital/cache that referenced this pull request Apr 19, 2024
actions#1049)

* Revert compression changes related to windows
 due to symlink issues

* Added tips and workarounds for cross os
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants