Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Checkout Issue in self hosted runner due to faulty submodule check-ins #1196

Merged
merged 6 commits into from Apr 14, 2023
Merged

Fix: Checkout Issue in self hosted runner due to faulty submodule check-ins #1196

merged 6 commits into from Apr 14, 2023

Commits on Mar 2, 2023

  1. Fix Self hosted runner issue wrt bad submodules - solution cleanup wo… 

    …rking space.
    @megamanics
    megamanics committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    7f14f1d View commit details
    Browse the repository at this point in the history

  2. Fix format with npm run format output

    @megamanics
    megamanics committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    39cfb84 View commit details
    Browse the repository at this point in the history

  3. Add mock implementation for new function submoduleStatus

    @megamanics
    megamanics committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    d12863b View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2023

  1. Merge branch 'main' into megamanics/main

    @Link-
    Link- committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    c8466ed View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2023

  1. Add 2 test cases for submodule status. 

    This commit adds tests to verify the behavior of the gitDirectoryHelper.prepareExistingDirectory() function when the submodule status is either true or false.
The test cleanWhenSubmoduleStatusIsFalse verifies that the function will clean the directory when the submodule status is false. The test sets up a mock implementation of git.submoduleStatus to always return false, writes a file to the repository, and then calls gitDirectoryHelper.prepareExistingDirectory(). The test verifies that the directory is cleaned and that git.tryClean() is called.
The test doesNotCleanWhenSubmoduleStatusIsTrue verifies that the function will not clean the directory when the submodule status is true. The test sets up a mock implementation of git.submoduleStatus to always return true, writes a file to the repository, and then calls gitDirectoryHelper.prepareExistingDirectory(). The test verifies that the directory is not cleaned, that the file and .git folder are present, and that git.tryClean() is called.
These tests ensure that the function behaves as expected based on the submodule status.
    @sminnie @megamanics
    sminnie authored and megamanics committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    bb965fa View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2023

  1. Codeql-Action Analyse revert v1 to v2

    @megamanics
    megamanics committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    6b84265 View commit details
    Browse the repository at this point in the history