Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass correct baseUrl to octokit #1288

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Pass correct baseUrl to octokit #1288

wants to merge 1 commit into from

Commits on Apr 13, 2023

  1. Pass correct baseUrl to octokit 

    The PR actions#1246 replaced the `getOctokit` method from the
`octokit-provider.ts` file with the `getOctokit` method from the
`@actions/github` package.
The octokit-provider was previously responsible for creating an Octokit
instance and setting the `baseUrl` via the `getServerApiUrl` helper
function. This function calls `getServerUrl` which reads the server url
from the `GITHUB_SERVER_URL` environment variable, which on GHES is set
to the enterprise instance.
This commit restores the previous behaviour by calling `getServerApiUrl`
in all places where an octokit instance is created.

Co-authored-by: Markus Wolf <mail@markus-wolf.de>
    @ZauberNerd @KnisterPeter
    ZauberNerd and KnisterPeter committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    590916f View commit details
    Browse the repository at this point in the history